Model-based tests for PersistentShardCoordinator.State
#5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdHomeAllocated` messages (akkadotnet#5967)" This reverts commit 4fa7abb.
|
Tried this with a complex configuration and the tests passed after several minutes.
No issues with the |
Aaronontheweb
changed the title
PersistentShardCoordinator.StatePersistentShardCoordinator.State
|
#5976 - must be merged first. |
Aaronontheweb
commented
May 31, 2022
| @@ -35,5 +35,13 @@ public static class FsharpDelegateHelper | |||
| value1 => { return Create<T2, T3, TResult>((value2, value3) => func(value1, value2, value3)); }; | |||
| return FSharpFunc<T1, FSharpFunc<T2, FSharpFunc<T3, TResult>>>.FromConverter(conv); | |||
| } | |||
|
|
|||
| public static FSharpFunc<T1, FSharpFunc<T2, FSharpFunc<T3, FSharpFunc<T4, TResult>>>> Create<T1, T2, T3, T4, TResult>( | |||
There was a problem hiding this comment.
Needed to support 4 argument FSharp functions
|
Failing tests are all unrelated. |
|
We should backport this to 1.5 but it's not urgent cc @Arkatufus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5604
Changes
Added model-based test with FsCheck to validate that
PersistentShardCoordinator.Stateis designed correctly.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):