Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Akka.Actor.Cancelable #6032

Merged
merged 8 commits into from
Jul 21, 2022
Merged

Improve Akka.Actor.Cancelable #6032

merged 8 commits into from
Jul 21, 2022

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Add new Create methods that takes CancellationToken params
  • Clean up the Dispose method
  • Expose the _isDisposed field as a property

Arkatufus added 5 commits July 6, 2022 00:28
@Arkatufus
Improve Cancelable
54e78fb 
- Add new Create methods that takes CancellationToken params
- Clean up the Dispose method
- Expose the _isDisposed field as a property
@Arkatufus
Merge branch 'dev' into Improve_Cancelable
dadb0d5
@Arkatufus
Update API Verify list
a4b9fc1
@Arkatufus
Merge branch 'Improve_Cancelable' of github.com:Arkatufus/akka.net in…
461475a 
…to Improve_Cancelable
@Arkatufus
Merge branch 'dev' into Improve_Cancelable
6de5404
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Jul 6, 2022
Aaronontheweb
Aaronontheweb requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look fine, but have questions on the underlying behavior.

src/core/Akka/Actor/Cancellation/Cancelable.cs Outdated Show resolved Hide resolved
@Arkatufus Arkatufus requested a review from Aaronontheweb July 19, 2022 16:34
Aaronontheweb
Aaronontheweb approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) July 19, 2022 19:46
@Aaronontheweb Aaronontheweb disabled auto-merge July 21, 2022 13:38
@Aaronontheweb Aaronontheweb merged commit e9b643f into akkadotnet:dev Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-actor
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb