Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT #6045] cleaned up IAsyncEnumerable Source to use local functions #6048

Conversation

Arkatufus
Copy link
Contributor

Cherry-picked from 0c92aac

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - provided that we're using the correct TestKit methods.

@Aaronontheweb Aaronontheweb added this to the 1.4.40 milestone Jul 22, 2022
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) July 22, 2022 14:23
@Arkatufus
Copy link
Contributor Author

We should be, had to downgrade all the async testkit methods

@Aaronontheweb Aaronontheweb merged commit fc777f3 into akkadotnet:v1.4 Jul 22, 2022
Aaronontheweb added a commit that referenced this pull request Jul 22, 2022
* Update RELEASE_NOTES.md for 1.4.40 release

* Add aminchenkov to the contributor list table

* Cherry-picked from 0c92aac (#6048)

Co-authored-by: Aaron Stannard <aaron@petabridge.com>

* Update RELEASE_NOTES.md for 1.4.40 release

* Add aminchenkov to the contributor list table

* Update RELEASE_NOTES.md

Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants