Require verbose logging for more gossip send/receive log statements. #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
pushed a commit
to Arkatufus/akka.net
that referenced
this pull request
Sep 7, 2022
…kkadotnet#6089) (cherry picked from commit 3b4ed91)
Aaronontheweb
pushed a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #6074
Changes
Akka.NET version 1.4.41 introduced verbose-debug-logging switch that is used to disable by default higher level of details in the debug log. However, in my previous PR I overlooked another "Received gossip" log statement that also result in high volume of log messages, as well as "Sending gossip" log messages. This PR adds VerboseDebugLogging requirement for these messages.
I checked the remaining log messages and they do not seem to cause excessive logging. There is one "Sending gossip..." log statement that I didn't wrap with a check for VerboseDebugLogging because it's written when requesting missing keys and only occurs occasionally, so I suppose it can be OK to always write it when Debug logging is enabled.