Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TestKitBase.InitializeTest to virtual so it can be deferred #6093

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Change TestKitBase.InitializeTest to virtual so it can be deferred
    This is needed for Akka.Hosting.TestKit

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need to backport to 1.5 also.

@Aaronontheweb Aaronontheweb added this to the 1.4.42 milestone Sep 10, 2022
@Aaronontheweb Aaronontheweb added akka-testkit Akka.NET Testkit issues api-change labels Sep 10, 2022
@Aaronontheweb Aaronontheweb merged commit 63639b9 into akkadotnet:v1.4 Sep 10, 2022
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request Sep 13, 2022
Aaronontheweb pushed a commit that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-testkit Akka.NET Testkit issues api-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants