Revert ConfigurationException due to binary incompatibility #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Oct 19, 2022
| @@ -16,11 +16,11 @@ namespace Akka.Configuration | |||
| /// </summary> | |||
| public class ConfigurationException : AkkaException | |||
| { | |||
| public static ConfigurationException NullOrEmptyConfig<T>(string path = null, string reason = null) | |||
| public static ConfigurationException NullOrEmptyConfig<T>(string path = null) | |||
There was a problem hiding this comment.
Reverting this back to the old method fingerprint
Arkatufus
commented
Oct 19, 2022
| @@ -35,7 +35,7 @@ public ClusterSettings(Config config, string systemName) | |||
| //TODO: Requiring! | |||
| var clusterConfig = config.GetConfig("akka.cluster"); | |||
| if (clusterConfig?.GetConfig("failure-detector") == null) | |||
| throw ConfigurationException.NullOrEmptyConfig<ClusterSettings>("akka.cluster", "Did you forgot to set the 'akka.cluster.provider' HOCON property to 'cluster'?"); | |||
| throw new ConfigurationException($"Failed to instantiate {nameof(ClusterSettings)}: Configuration does not contain `akka.cluster` node. Did you forgot to set the 'akka.cluster.provider' HOCON property to 'cluster'?"); | |||
There was a problem hiding this comment.
Just bake the exception message instead of using the helper method
|
Done |
Aaronontheweb
approved these changes
Oct 19, 2022
|
@Arkatufus going to give tests a chance to run, then we can push a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6200
Changes
Revert changes to the static method