Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read stash capacity from actor's mailbox or dispatcher configuration #6323

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

ismaelhamed
Copy link
Member

Fixes reading stash capacity from actor's mailbox or dispatcher configuration.

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Jan 3, 2023
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// Get (possibly aliased) dispatcher config. Returns empty config if not found.
/// </summary>
[InternalApi]
public static Config GetConfig(Config config, string id, int depth = 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// mailboxes, and thus should be validated that the `pushTimeOut` is greater than 0.
/// </para>
/// </summary>
public interface IProducesPushTimeoutSemanticsMailbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_mailboxNonZeroPushTimeoutWarningIssued = true;
}

// good; nothing to see here, move along, sir.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 4d124ce into akkadotnet:dev Jan 3, 2023
Aaronontheweb added a commit that referenced this pull request Jan 24, 2023
)

* Read stash capacity from actor's mailbox or dispatcher configuration (#6323)

* Added support for `UnrestrictedStash` (#6325)

* Add API for UntypedActorWithStash types (#6327)

Co-authored-by: Aaron Stannard <aaron@petabridge.com>

Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants