Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogEvent type of UnhandledMessage was changed to INFO in Akka.TestKit (#6354). #6360

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

F0b0s
Copy link
Contributor

@F0b0s F0b0s commented Jan 24, 2023

Fixes #6354

Changes

TestEventListener produce Warning LogEvent for UnhandledMessage instead of Info. Also minor stylefixes.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

var warning = new Warning(rcp.Path.ToString(), rcp.GetType(), "Unhandled message from " + un.Sender + ": " + un.Message);
if(!ShouldFilter(warning))
Print(warning);
var info = new Info(rcp.Path.ToString(), rcp.GetType(), "Unhandled message from " + un.Sender + ": " + un.Message);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is a Warning in the JVM. Are we sure this is the root cause of the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i see in Akka.Event.DeadLetterListener message UnhandledMessage is handled as Info message instead of TestEventListener.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case UnhandledMessage unhandled:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @F0b0s is right - in the real logging system unhandled messages get logged as Info unless he's not looking in the right place. I did a quick (not complete) look through the code and the DeadLetterListener is the only built-in subscriber for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found solution for #6316 and it's blocked by this PR. When it will be merged i can create MR for it.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added the akka-testkit Akka.NET Testkit issues label Jan 26, 2023
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Jan 26, 2023
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 26, 2023 16:27
@Aaronontheweb Aaronontheweb merged commit a447760 into akkadotnet:dev Jan 26, 2023
@F0b0s F0b0s deleted the test_kit_logging_fix branch May 3, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-testkit Akka.NET Testkit issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning log event is filtered but never shows up in the actual log
3 participants