-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogEvent type of UnhandledMessage was changed to INFO in Akka.TestKit (#6354). #6360
Conversation
var warning = new Warning(rcp.Path.ToString(), rcp.GetType(), "Unhandled message from " + un.Sender + ": " + un.Message); | ||
if(!ShouldFilter(warning)) | ||
Print(warning); | ||
var info = new Info(rcp.Path.ToString(), rcp.GetType(), "Unhandled message from " + un.Sender + ": " + un.Message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is a Warning
in the JVM. Are we sure this is the root cause of the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As i see in Akka.Event.DeadLetterListener
message UnhandledMessage
is handled as Info message instead of TestEventListener
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case UnhandledMessage unhandled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @F0b0s is right - in the real logging system unhandled messages get logged as Info unless he's not looking in the right place. I did a quick (not complete) look through the code and the DeadLetterListener
is the only built-in subscriber for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found solution for #6316 and it's blocked by this PR. When it will be merged i can create MR for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6354
Changes
TestEventListener produce Warning LogEvent for UnhandledMessage instead of Info. Also minor stylefixes.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):