Fix for issue #6377 #6378
Merged
Fix for issue #6377 #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created a setting property LogSerializerOverrideOnStart to reflect if warning should be logged or not * updated default config to enable logging for this issue by default * added property to the configuration Spezifikation
|
... no idea what is wrong here after trying to run the tests again. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6377
Changes
Allows to suppress the WARNING message about changes in the serializer settings.
Set the value in the config
log-serializer-override-on-start = offto disable the logging of the message.
The default value is
onto get notified at the first time and check if the change was by intention.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
It is worth to mention that the solution has the shortcomming of a global enable/disable behavior. It would be nice to just mark the intended change (for example by having a white list of checked changes configured in a mapping table (type <-> serializer)) but this seems to be an overkill for the rare cases to me.
I only added the change to the default config and documented the code (according the other configuration properties documentation). However, I wrote no Markdown files or so. Please ask, if required.
The changes do not affect the performance, so I added no benchmarks.