Harden Option<T> by disallowing null value
#6426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Feb 21, 2023
| @@ -5122,10 +5122,12 @@ namespace Akka.Util | |||
| public struct Option<T> | |||
| { | |||
| public static readonly Akka.Util.Option<T> None; | |||
| [System.ObsoleteAttribute("Use Option<T>.Create() instead")] | |||
| @@ -50,7 +58,7 @@ public Option(T value) | |||
| /// </summary> | |||
| /// <param name="value">The object to convert</param> | |||
| /// <returns>The result of the conversion.</returns> | |||
| public static implicit operator Option<T>(T value) => new Option<T>(value); | |||
| public static implicit operator Option<T>(T value) => Create(value); | |||
There was a problem hiding this comment.
We should enable nullable in the future for this project - there's ways to do it in increments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4604
Hardens Option
Changes
Option<T>constructor throw anArgumentNullExceptionwhen null value is passed inCreatestatic method that returns aNonewhen null is passed in