Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all obsolete methods from Akka.Cluster.Sharding #6441

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Remove all obsolete methods from Akka.Cluster.Sharding #6441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
449854c
Remove all obsolete methods from Akka.Cluster.Sharding
Arkatufus Feb 24, 2023
80ee879
Merge branch 'dev' into REMOVE-obsolete-methods-cluster.sharding
Arkatufus Feb 24, 2023
aaeed00
Revert recent changes
Arkatufus Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/contrib/cluster/Akka.Cluster.Sharding/ShardedDaemonProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,6 @@ public void Init(string name, int numberOfInstances, Func<int, Props> propsFacto
public void Init(string name, int numberOfInstances, Func<int, Props> propsFactory, object stopMessage) =>
Init(name, numberOfInstances, propsFactory, ShardedDaemonProcessSettings.Create(_system), stopMessage);

/// <summary>
/// Start a specific number of actors, each with a unique numeric id in the set, that is then kept alive in the cluster.
/// </summary>
/// <param name="name">TBD</param>
/// <param name="numberOfInstances">TBD</param>
/// <param name="propsFactory">Given a unique id of `0` until `numberOfInstance` create an entity actor.</param>
/// <param name="settings">TBD</param>
[Obsolete("Use the overloaded one which accepts a stopMessage instead.")]
public void Init(string name, int numberOfInstances, Func<int, Props> propsFactory, ShardedDaemonProcessSettings settings) =>
Init(name, numberOfInstances, propsFactory, settings, null);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete since v.1.4.22 (2 years)


/// <summary>
/// Start a specific number of actors, each with a unique numeric id in the set, that is then kept alive in the cluster.
/// </summary>
Expand Down
8 changes: 4 additions & 4 deletions src/contrib/cluster/Akka.Cluster.Sharding/ShardingMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,12 +427,12 @@ public sealed class ShardRegionStats : IClusterShardingSerializable, IEquatable<
/// Creates a new ShardRegionStats instance.
/// </summary>
/// <param name="stats">the region stats mapping of `ShardId` to number of entities</param>
[Obsolete]
Arkatufus marked this conversation as resolved.
Show resolved Hide resolved
[Obsolete("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public ShardRegionStats(IImmutableDictionary<ShardId, int> stats)
: this(stats, ImmutableHashSet<ShardId>.Empty)
{
}

/// <summary>
/// Creates a new ShardRegionStats instance.
/// </summary>
Expand Down Expand Up @@ -520,12 +520,12 @@ public sealed class CurrentShardRegionState : IClusterShardingSerializable, IEqu
/// TBD
/// </summary>
/// <param name="shards">TBD</param>
[Obsolete]
[Obsolete("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public CurrentShardRegionState(IImmutableSet<ShardState> shards)
Arkatufus marked this conversation as resolved.
Show resolved Hide resolved
: this(shards, ImmutableHashSet<ShardId>.Empty)
{
}

/// <summary>
/// TBD
/// </summary>
Expand Down
6 changes: 2 additions & 4 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterSharding.Core.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> Shards;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards) { }
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand Down Expand Up @@ -220,7 +220,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableDictionary<string, int> Stats;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats) { }
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand All @@ -246,8 +246,6 @@ namespace Akka.Cluster.Sharding
public static Akka.Cluster.Sharding.ShardedDaemonProcess Get(Akka.Actor.ActorSystem system) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, object stopMessage) { }
[System.ObsoleteAttribute("Use the overloaded one which accepts a stopMessage instead.")]
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings, object stopMessage) { }
}
public class ShardedDaemonProcessExtensionProvider : Akka.Actor.ExtensionIdProvider<Akka.Cluster.Sharding.ShardedDaemonProcess>
Expand Down
6 changes: 2 additions & 4 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterSharding.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> Shards;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards) { }
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand Down Expand Up @@ -220,7 +220,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableDictionary<string, int> Stats;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats) { }
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand All @@ -246,8 +246,6 @@ namespace Akka.Cluster.Sharding
public static Akka.Cluster.Sharding.ShardedDaemonProcess Get(Akka.Actor.ActorSystem system) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, object stopMessage) { }
[System.ObsoleteAttribute("Use the overloaded one which accepts a stopMessage instead.")]
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings, object stopMessage) { }
}
public class ShardedDaemonProcessExtensionProvider : Akka.Actor.ExtensionIdProvider<Akka.Cluster.Sharding.ShardedDaemonProcess>
Expand Down
6 changes: 2 additions & 4 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterSharding.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> Shards;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards) { }
public CurrentShardRegionState(System.Collections.Immutable.IImmutableSet<Akka.Cluster.Sharding.ShardState> shards, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand Down Expand Up @@ -220,7 +220,7 @@ namespace Akka.Cluster.Sharding
{
public readonly System.Collections.Immutable.IImmutableSet<string> Failed;
public readonly System.Collections.Immutable.IImmutableDictionary<string, int> Stats;
[System.ObsoleteAttribute()]
[System.ObsoleteAttribute("Use constructor with `failed` argument. Obsolete since 1.5.0-alpha1")]
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats) { }
public ShardRegionStats(System.Collections.Immutable.IImmutableDictionary<string, int> stats, System.Collections.Immutable.IImmutableSet<string> failed) { }
public override bool Equals(object obj) { }
Expand All @@ -246,8 +246,6 @@ namespace Akka.Cluster.Sharding
public static Akka.Cluster.Sharding.ShardedDaemonProcess Get(Akka.Actor.ActorSystem system) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, object stopMessage) { }
[System.ObsoleteAttribute("Use the overloaded one which accepts a stopMessage instead.")]
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings) { }
public void Init(string name, int numberOfInstances, System.Func<int, Akka.Actor.Props> propsFactory, Akka.Cluster.Sharding.ShardedDaemonProcessSettings settings, object stopMessage) { }
}
public class ShardedDaemonProcessExtensionProvider : Akka.Actor.ExtensionIdProvider<Akka.Cluster.Sharding.ShardedDaemonProcess>
Expand Down