Remove obsolete methods from Akka.IO #6456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Feb 27, 2023
| @@ -76,12 +76,6 @@ public abstract class AbstractSocketOptionV2 : SocketOptionV2 { } | |||
| /// </summary> | |||
| public class DatagramChannelCreator : SocketOption | |||
| { | |||
| [Obsolete(message:"Please use the method with AddressFamily parameter. Using this method will always return an IPv6 bound UDP endpoint.")] | |||
| public virtual Socket Create() | |||
There was a problem hiding this comment.
Obsolete since v1.4.28 (2 years)
Arkatufus
commented
Feb 27, 2023
| @@ -176,12 +176,6 @@ public NoAck(object token) | |||
| /// </summary> | |||
| public sealed class Send : Command | |||
| { | |||
| [Obsolete("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(ByteString, EndPoint, Event)` instead.")] | |||
| public Send(IEnumerator<ByteBuffer> payload, EndPoint target, Event ack) | |||
There was a problem hiding this comment.
Obsolete since v1.3.13 (6 years)
Arkatufus
commented
Feb 27, 2023
| @@ -165,12 +165,6 @@ public NoAck(object token) | |||
| /// </summary> | |||
| public sealed class Send : Command | |||
| { | |||
| [Obsolete("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(ByteString, EndPoint, Event)` instead.")] | |||
| public Send(IEnumerator<ByteBuffer> payload, Event ack) | |||
There was a problem hiding this comment.
Obsolete since v1.3.13 (6 years)
Arkatufus
commented
Feb 27, 2023
| @@ -46,27 +46,6 @@ public static UdpSettings Create(Config config) | |||
| fileIoDispatcher: config.GetString("file-io-dispatcher", "akka.actor.default-dispatcher")); | |||
| } | |||
|
|
|||
| // directBufferSize and maxDirectBufferPoolSize parameter are byterot, remove this in v1.5 | |||
| [Obsolete("Please the constructor without directBufferSize and maxDirectBufferPoolSize parameter")] | |||
| public UdpSettings( | |||
There was a problem hiding this comment.
Obsolete since 1.4.28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.