fixed issues with AwaitConditionAsync
#6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Feb 28, 2023
| @@ -123,6 +127,9 @@ public interface IEventFilterApplier | |||
| /// <param name="action">The action.</param> | |||
| /// <param name="cancellationToken"></param> | |||
| Task ExpectAsync(int expectedCount, TimeSpan timeout, Func<Task> action, CancellationToken cancellationToken = default); | |||
|
|
|||
| [Obsolete("Use ExpectAsync<T>(expectedCount, TimeSpan, Func<Task<T>>) instead. This method only exists to support backwards compatibility as of Akka.NET v1.5.")] | |||
There was a problem hiding this comment.
Added Obsolete APIs for __Async methods that were introduced in the v1.4 TestKit that accepted Action overloads.
| @@ -568,6 +568,14 @@ public async ValueTask<T> ExpectMsgAnyOfAsync<T>(IEnumerable<T> messages, Cancel | |||
|
|
|||
| return (T)o; | |||
| } | |||
|
|
|||
| public IReadOnlyCollection<T> ExpectMsgAllOf<T>( | |||
There was a problem hiding this comment.
Needed to add this for backwards compat.
| @@ -606,6 +614,13 @@ await foreach (var item in enumerable) | |||
| yield return item; | |||
| } | |||
| } | |||
|
|
|||
| public IReadOnlyCollection<T> ExpectMsgAllOf<T>( | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixing API issues reported in #6466
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):