Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Args() on LogMessage #6472

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Feb 28, 2023

Changes

need this for Serilog support

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

need this for Serilog support
@Aaronontheweb
Copy link
Member Author

Looks like racy unit tests, but a legit DocFx failure

@@ -75,6 +83,8 @@ public override string Unformatted()
{
return Arg.ToString();
}

public override IEnumerable<object> Parameters() => Arg;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this to make Serilog happy, but can also be used for debug formatting.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review February 28, 2023 21:48
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 0608656 into akkadotnet:dev Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants