Drop support for .NETCore3.1 in Tests and samples
#6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaba
commented
Mar 17, 2023
| @@ -56,7 +56,6 @@ let incrementalistReport = output @@ "incrementalist.txt" | |||
|
|
|||
| // Configuration values for tests | |||
| let testNetFrameworkVersion = "net471" | |||
| let testNetCoreVersion = "netcoreapp3.1" | |||
There was a problem hiding this comment.
I remove "netcoreapp3.1" from build.fsx - everything.
| @@ -3,7 +3,7 @@ | |||
| <Import Project="..\..\common.props" /> | |||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFrameworks>$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks> | |||
There was a problem hiding this comment.
I only removed this everywhere........
Aaronontheweb
approved these changes
Mar 17, 2023
| @@ -4,8 +4,8 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <AssemblyTitle>Akka.Tests</AssemblyTitle> | |||
| <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks> | |||
| <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks> | |||
| <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(NetFrameworkTestVersion);$(NetTestVersion)</TargetFrameworks> | |||
There was a problem hiding this comment.
In a different pull request, we can probably get rid of these conditionals - I believe they were added many years ago for working around issues with Mono execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Drop support for .NET Core 3.1
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):