Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpectNextUnordered remove the Obsolete attribute #6547

Merged
merged 2 commits into from
Mar 23, 2023
Merged

ExpectNextUnordered remove the Obsolete attribute #6547

merged 2 commits into from
Mar 23, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 23, 2023

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@eaba eaba changed the title ExpectNextUnordered remove the Obsolete attribute ExpectNextUnordered remove the Obsolete attribute Mar 23, 2023
Aaronontheweb
Aaronontheweb approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Streams.TestKit/TestSubscriber_Fluent.cs Show resolved Hide resolved
Aaronontheweb
Aaronontheweb requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, need to take a look - this is a blocking method.

src/core/Akka.Streams.TestKit/TestSubscriber_Fluent.cs Show resolved Hide resolved
@Aaronontheweb Aaronontheweb merged commit 996cac7 into akkadotnet:dev Mar 23, 2023
@eaba eaba deleted the ExpectNextUnordered branch March 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus left review comments

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eaba @Aaronontheweb @Arkatufus