fix MergeHub_must_work_with_long_streams_when_buffer_size_is_1 #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99% sure that trying to ReSharper this into a method that doesn't use tail recursion actually created a bug here that can occur for really small partitions - making the `firstAttempt` value mutable across all possible instances results in behavior that actually isn't comparable to using isolated function invocations in all instances. Going to run this through CI and see if that adds up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is currently the raciest test in the entire test suite.
99% sure that trying to ReSharper this into a method that doesn't use tail recursion actually created a bug here that can occur for really small partitions - making the
firstAttemptvalue mutable across all possible instances results in behavior that actually isn't comparable to using isolated function invocations in all instances. Going to run this through CI and see if that adds up.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):