Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[65-74] SubscriberSinkSpec #6613

Merged
merged 4 commits into from
Mar 30, 2023
Merged

[65-74] SubscriberSinkSpec #6613

merged 4 commits into from
Mar 30, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 26, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

Aaronontheweb
Aaronontheweb requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async methods instead of work-arounds

src/core/Akka.Streams.Tests/Dsl/SubscriberSinkSpec.cs Outdated
@@ -38,6 +38,7 @@ public void A_Flow_with_SubscriberSink_must_publish_elements_to_the_subscriber()
c.ExpectNext(2);
c.ExpectNext(3);
c.ExpectComplete();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async methods here

Aaronontheweb
Aaronontheweb approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 2e1a137 into akkadotnet:dev Mar 30, 2023
@eaba eaba deleted the SubscriberSinkSpec branch March 30, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb