Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[69-74] KeepGoingStageSpec #6617

Merged
merged 4 commits into from
Mar 28, 2023
Merged

[69-74] KeepGoingStageSpec #6617

merged 4 commits into from
Mar 28, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 26, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

Aaronontheweb
Aaronontheweb approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) March 27, 2023 21:39
Aaronontheweb
Aaronontheweb requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use modern async testkit APIs instead of work-arounds

src/core/Akka.Streams.Tests/Implementation/Fusing/KeepGoingStageSpec.cs Outdated
@@ -231,14 +230,14 @@ public void A_stage_with_keep_going_must_still_be_alive_after_all_ports_have_bee
// PostStop should not be concurrent with the event handler. This event here tests this.
ExpectMsg<EndOfEventHandler>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ExpectMsgAsync

src/core/Akka.Streams.Tests/Implementation/Fusing/KeepGoingStageSpec.cs Outdated
@@ -269,15 +268,14 @@ public void A_stage_with_keep_going_must_still_be_alive_after_all_ports_have_bee
// PostStop should not be concurrent with the event handler. This event here tests this.
ExpectMsg<EndOfEventHandler>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ExpectMsgAsync

src/core/Akka.Streams.Tests/Implementation/Fusing/KeepGoingStageSpec.cs Outdated
@@ -337,6 +334,7 @@ public void A_stage_with_keep_going_must_close_down_earls_if_keepAlive_is_not_re
maybePromise.TrySetResult(0);
ExpectMsg<UpstreamCompleted>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ExpectMsgAsync

auto-merge was automatically disabled March 28, 2023 14:47

Head branch was pushed to by a user without write access

Aaronontheweb
Aaronontheweb approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 7472bd5 into akkadotnet:dev Mar 28, 2023
@eaba eaba deleted the KeepGoingStageSpec branch March 29, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb