Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS0618] AbstractStage Warning Disable #6672

Merged
merged 5 commits into from
May 3, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Apr 25, 2023

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

@@ -59,7 +63,9 @@ internal class PushPullGraphLogic<TIn, TOut> : GraphStageLogic, IDetachedContext
/// <summary>
/// TBD
/// </summary>
#pragma warning disable CS0618 // Type or member is obsolete
public AbstractStage<TIn, TOut> Stage { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What stage are we supposed to replace AbstractStage with @eaba ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please use GraphStage instead. [1.1.2]" @Aaronontheweb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Obsolete("Please use GraphStage instead. [1.1.2]")]
public abstract class AbstractStage<TIn, TOut> : IStage<TIn, TOut>
{
/// <summary>
/// TBD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// <typeparam name="TOut">TBD</typeparam>
[Obsolete("Please use GraphStage instead. [1.1.0]")]
public interface IStage<in TIn, out TOut> { }

@Aaronontheweb Aaronontheweb merged commit 90d6349 into akkadotnet:dev May 3, 2023
@eaba eaba deleted the abstract_stage_obsolete branch May 8, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants