-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS0618] AbstractStage Warning Disable #6672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question
@@ -59,7 +63,9 @@ internal class PushPullGraphLogic<TIn, TOut> : GraphStageLogic, IDetachedContext | |||
/// <summary> | |||
/// TBD | |||
/// </summary> | |||
#pragma warning disable CS0618 // Type or member is obsolete | |||
public AbstractStage<TIn, TOut> Stage { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What stage are we supposed to replace AbstractStage
with @eaba ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Please use GraphStage instead. [1.1.2]" @Aaronontheweb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akka.net/src/core/Akka.Streams/Stage/AbstractStage.cs
Lines 389 to 393 in b688e5c
[Obsolete("Please use GraphStage instead. [1.1.2]")] | |
public abstract class AbstractStage<TIn, TOut> : IStage<TIn, TOut> | |
{ | |
/// <summary> | |
/// TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
akka.net/src/core/Akka.Streams/Stage/Stage.cs
Lines 33 to 36 in b688e5c
/// <typeparam name="TOut">TBD</typeparam> | |
[Obsolete("Please use GraphStage instead. [1.1.0]")] | |
public interface IStage<in TIn, out TOut> { } | |
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):