[CS0420] ActorCell Warning Disable
#6683
Conversation
src/core/Akka/Actor/ActorCell.cs
Outdated
| public Mailbox Mailbox => Volatile.Read(ref _mailboxDoNotCallMeDirectly); | ||
| #pragma warning restore CS0420 // A reference to a volatile field will not be treated as volatile |
There was a problem hiding this comment.
-
A volatile field should not normally be passed using a ref or out parameter, since it will not be treated as volatile within the scope of the function. There are exceptions to this, such as when calling an interlocked API. As with any warning, you may use the [#pragma warning](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives#pragma-warning) to disable this warning in those rare cases where you are intentionally using a volatile field as a reference parameter.https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0420?f1url=%3FappId%3Droslyn%26k%3Dk(CS0420) -
public Mailbox Mailbox => _mailboxDoNotCallMeDirectly;
src/core/Akka/Actor/ActorCell.cs
Outdated
| @@ -91,7 +91,9 @@ public ActorCell(ActorSystemImpl system, IInternalActorRef self, Props props, Me | |||
| /// <summary> | |||
| /// TBD | |||
| /// </summary> | |||
| #pragma warning disable CS0420 // A reference to a volatile field will not be treated as volatile | |||
| public Mailbox Mailbox => Volatile.Read(ref _mailboxDoNotCallMeDirectly); | |||
There was a problem hiding this comment.
We should probably remove the Volatile.Read call - since the field is already volatile.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):