Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS0618] StreamRefsSpec Sink.ActorRef<TIn>(IActorRef, object) is obsolete #6691

Merged
merged 2 commits into from
Apr 27, 2023
Merged

[CS0618] StreamRefsSpec Sink.ActorRef<TIn>(IActorRef, object) is obsolete #6691

merged 2 commits into from
Apr 27, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Apr 27, 2023

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

eaba
eaba commented Apr 27, 2023
View reviewed changes
Copy link
Contributor Author

@eaba eaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes

src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
@@ -94,7 +94,7 @@ protected override bool Receive(object message)
* We write out code, knowing that the other side will stream the data into it.
* For them it's a Sink; for us it's a Source.
*/
var sink = StreamRefs.SinkRef<string>().To(Sink.ActorRef<string>(_probe, "<COMPLETE>"))
var sink = StreamRefs.SinkRef<string>().To(Sink.ActorRef<string>(_probe, "<COMPLETE>", ex => new Status.Failure(ex)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into Sink<TIn, NotUsed> ActorRef<TIn>(IActorRef actorRef, object onCompleteMessage, Func<Exception, object> onFailureMessage)

src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
@@ -109,7 +109,7 @@ protected override bool Receive(object message)
{
var sink = StreamRefs.SinkRef<string>()
.WithAttributes(StreamRefAttributes.CreateSubscriptionTimeout(TimeSpan.FromMilliseconds(500)))
.To(Sink.ActorRef<string>(_probe, "<COMPLETE>"))
.To(Sink.ActorRef<string>(_probe, "<COMPLETE>", ex => new Status.Failure(ex)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into Sink<TIn, NotUsed> ActorRef<TIn>(IActorRef actorRef, object onCompleteMessage, Func<Exception, object> onFailureMessage)

src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
@@ -242,7 +242,7 @@ public void SourceRef_must_send_messages_via_remoting()
_remoteActor.Tell("give");
var sourceRef = ExpectMsg<ISourceRef<string>>();

sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>"), Materializer);
sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>", ex => new Status.Failure(ex)), Materializer);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into Sink<TIn, NotUsed> ActorRef<TIn>(IActorRef actorRef, object onCompleteMessage, Func<Exception, object> onFailureMessage)

src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
@@ -255,7 +255,7 @@ public void SourceRef_must_fail_when_remote_source_failed()
_remoteActor.Tell("give-fail");
var sourceRef = ExpectMsg<ISourceRef<string>>();

sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>"), Materializer);
sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>", ex => new Status.Failure(ex)), Materializer);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into Sink<TIn, NotUsed> ActorRef<TIn>(IActorRef actorRef, object onCompleteMessage, Func<Exception, object> onFailureMessage)

src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
@@ -269,7 +269,7 @@ public void SourceRef_must_complete_properly_when_remote_source_is_empty()
_remoteActor.Tell("give-complete-asap");
var sourceRef = ExpectMsg<ISourceRef<string>>();

sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>"), Materializer);
sourceRef.Source.RunWith(Sink.ActorRef<string>(_probe.Ref, "<COMPLETE>", ex => new Status.Failure(ex)), Materializer);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed into Sink<TIn, NotUsed> ActorRef<TIn>(IActorRef actorRef, object onCompleteMessage, Func<Exception, object> onFailureMessage)

Aaronontheweb
Aaronontheweb approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 468f167 into akkadotnet:dev Apr 27, 2023
@eaba eaba deleted the StreamRefsSpec branch April 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb