Added spec to demonstrate failed snapshot-only recovery #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests whether a persistent actor will properly fail during a failed snapshot recovery or during a timed out one. This is all without ever having saved an event to the journal, so the `MaxSeqNo` is set to `0`.
Aaronontheweb
commented
Jun 28, 2023
| @@ -3,7 +3,7 @@ | |||
| <PropertyGroup> | |||
| <AssemblyTitle>Akka.Persistence.TestKit</AssemblyTitle> | |||
| <Description>TestKit for writing tests for Akka.NET Persistance module.</Description> | |||
| <TargetFrameworks>$(NetStandardLibVersion)</TargetFrameworks> | |||
| <TargetFrameworks>$(NetStandardLibVersion);$(NetLibVersion)</TargetFrameworks> | |||
There was a problem hiding this comment.
Added dual-targeting to the Akka.Persistence.TestKit (net6)
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\..\contrib\serializers\Akka.Serialization.Hyperion\Akka.Serialization.Hyperion.csproj" /> | |||
| <ProjectReference Include="..\Akka.Persistence.TestKit.Xunit2\Akka.Persistence.TestKit.Xunit2.csproj" /> | |||
There was a problem hiding this comment.
Referenced the Akka.Persistence.TestKit so I could more easily simulate journal / snapshot store failures
| { | ||
| var actor2 = Sys.ActorOf(Props.Create(() => new PersistentActor("p1", probe.Ref))); | ||
| Watch(actor2); | ||
| await probe.ExpectNoMsgAsync(); |
There was a problem hiding this comment.
Should not receive an SnapshotSaved here as the actor will not successfully complete recovery under either scenario.
| var actor2 = Sys.ActorOf(Props.Create(() => new PersistentActor("p1", probe.Ref))); | ||
| Watch(actor2); | ||
| await probe.ExpectNoMsgAsync(); | ||
| await ExpectTerminatedAsync(actor2); |
There was a problem hiding this comment.
Actor should have self-terminated by now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests whether a persistent actor will properly fail during a failed snapshot recovery or during a timed out one. This is all without ever having saved an event to the journal, so the
MaxSeqNois set to0.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):