Bump XunitVersion from 2.5.0 to 2.5.1 #6920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps `XunitVersion` from 2.5.0 to 2.5.1. Updates `xunit` from 2.5.0 to 2.5.1 - [Commits](xunit/xunit@2.5.0...2.5.1) Updates `xunit.runner.visualstudio` from 2.5.0 to 2.5.1 - [Commits](xunit/xunit@2.5.0...2.5.1) Updates `xunit.runner.utility` from 2.5.0 to 2.5.1 - [Commits](xunit/xunit@2.5.0...2.5.1) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: xunit.runner.utility dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
Aaronontheweb
requested changes
Sep 19, 2023
There was a problem hiding this comment.
According to the DocFx build stage, the new version of xUnit includes a bunch of new rulesets that are failing inside our test suite. CC @Arkatufus
This might be a bigger project than we're willing to do right at this moment.
|
its basically a roslyn analyzer that detects if you're calling |
|
Most of these codes can be refactored to use the new |
|
but yeah, we're doing sync over async in a lot of our unit test methods, its a huge technical debt. |
Aaronontheweb
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
XunitVersionfrom 2.5.0 to 2.5.1.Updates
xunitfrom 2.5.0 to 2.5.1Commits
9dc851bv2.5.186b0eef#2770: Make SerializationHelper publicf49dafcFile re-sort for SerializationHelper & XunitSerializationInfod0004ae#2773: Add Assert.RaisesAny and Assert.RaisesAnyAsync non-generic for EventAr...c1dba28Latest assertionsb7c828eMove .editorconfig up into contentFiles08e74e7Add .editorconfig to assert source NuGet package to indicate generated code (...79f411a#2767: Verify types match when comparing FileSystemInfo values (v2)9c28f58Latest dependencies63dce4f#2767: Special case FileSystemInfo objects by just comparing the FullName in ...Updates
xunit.runner.visualstudiofrom 2.5.0 to 2.5.1Commits
9dc851bv2.5.186b0eef#2770: Make SerializationHelper publicf49dafcFile re-sort for SerializationHelper & XunitSerializationInfod0004ae#2773: Add Assert.RaisesAny and Assert.RaisesAnyAsync non-generic for EventAr...c1dba28Latest assertionsb7c828eMove .editorconfig up into contentFiles08e74e7Add .editorconfig to assert source NuGet package to indicate generated code (...79f411a#2767: Verify types match when comparing FileSystemInfo values (v2)9c28f58Latest dependencies63dce4f#2767: Special case FileSystemInfo objects by just comparing the FullName in ...Updates
xunit.runner.utilityfrom 2.5.0 to 2.5.1Commits
9dc851bv2.5.186b0eef#2770: Make SerializationHelper publicf49dafcFile re-sort for SerializationHelper & XunitSerializationInfod0004ae#2773: Add Assert.RaisesAny and Assert.RaisesAnyAsync non-generic for EventAr...c1dba28Latest assertionsb7c828eMove .editorconfig up into contentFiles08e74e7Add .editorconfig to assert source NuGet package to indicate generated code (...79f411a#2767: Verify types match when comparing FileSystemInfo values (v2)9c28f58Latest dependencies63dce4f#2767: Special case FileSystemInfo objects by just comparing the FullName in ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)