Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant string interpolation #6938

Merged
merged 6 commits into from
Oct 11, 2023
Merged

remove redundant string interpolation #6938

merged 6 commits into from
Oct 11, 2023

Conversation

SimonCropp
Copy link
Contributor

No description provided.

Arkatufus
Arkatufus approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) October 3, 2023 13:42
Aaronontheweb
Aaronontheweb previously requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a real test failure in one of the suites

Assert.Contains() Failure: Sub-string not found
String: "Illegal actor name [üß]. Actor paths MUST"···
Not found: "include only ASCII"

@Aaronontheweb
Copy link
Member

Name of the failing test: Akka.Tests.Actor.LocalActorRefProviderSpec.An_ActorRefFactory_must_throw_suitable_exceptions_for_malformed_actor_names(name: "üß", expectedExceptionMessageSubstring: "include only ASCII")

@Aaronontheweb
Copy link
Member

This error is happening in dev too so it's not this PR - we will track this down

@Arkatufus Arkatufus dismissed Aaronontheweb’s stale review October 3, 2023 18:20

Test failure were not caused by this PR

@Aaronontheweb Aaronontheweb merged commit f937db3 into akkadotnet:dev Oct 11, 2023
@SimonCropp SimonCropp deleted the remove-redundant-string-interpolation branch October 12, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

@Aaronontheweb Aaronontheweb Aaronontheweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @Aaronontheweb @Arkatufus