Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sealed uninherited internal classes in Akka.Streams and Akka.Remote #6940

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Sealed uninherited internal classes in Akka.Streams and Akka.Remote #6940

merged 3 commits into from
Jan 4, 2024

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Oct 2, 2023 •
edited
Loading

Also:

  • In the files that were touched, fields that weren't being modified outside the constructors were made readonly
  • In the classes that were sealed, new protected members were made private
  • Exceptions were not sealed because they had a protected serialization constructors. It may well be the case that this constructor works well if it's made private, but I don't know the codebase well enough, so I will leave those alone for now

Aaronontheweb
Aaronontheweb approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Remote/Endpoint.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Remote/EndpointManager.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Remote/PhiAccrualFailureDetector.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/core/Akka.Remote/Remoting.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 4, 2024 15:48
@Aaronontheweb Aaronontheweb changed the title Sealed uninherited internal classes in Akka.Streams Sealed uninherited internal classes in Akka.Streams and Akka.Remote Jan 4, 2024
@Aaronontheweb Aaronontheweb disabled auto-merge January 4, 2024 16:55
@Aaronontheweb Aaronontheweb merged commit 5620f02 into akkadotnet:dev Jan 4, 2024
9 of 12 checks passed
@Lehonti Lehonti deleted the improvement1 branch January 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-remote akka-streams perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lehonti @Aaronontheweb