Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor childStats requestRestartPermission algorithm" #696

Merged
merged 1 commit into from
Mar 1, 2015

Conversation

HCanber
Copy link
Contributor

@HCanber HCanber commented Mar 1, 2015

Reverts #689

PR #689 has altered the algorithm. Unfortunately it introduced several bugs, and needs to be reverted, as support for negative values have been completely removed.

The values for maxNrOfRetries and withinTimeMilliseconds are specified when creating AllForOneStrategy and OneForOneStrategy. From the docs for these constructors:
-- maxNrOfRetries: the number of times a child actor is allowed to be restarted, negative value means no limit, if the limit is exceeded the child actor is stopped.
-- withinTimeMilliseconds: duration in milliseconds of the time window for maxNrOfRetries, negative values means no window.
#689 made these calls do the incorrect thing:

RequestRestartPermission(-1,-1)
RequestRestartPermission(10,-1)
RequestRestartPermission(-1, 10)

rogeralsing added a commit that referenced this pull request Mar 1, 2015
…tRestartPermission

Revert "Refactor childStats requestRestartPermission algorithm"
@rogeralsing rogeralsing merged commit c7669fe into dev Mar 1, 2015
@rogeralsing rogeralsing deleted the revert-689-refactoring-requestRestartPermission branch March 1, 2015 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants