Revert "Refactor childStats requestRestartPermission algorithm" #696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #689
PR #689 has altered the algorithm. Unfortunately it introduced several bugs, and needs to be reverted, as support for negative values have been completely removed.
The values for
maxNrOfRetries
andwithinTimeMilliseconds
are specified when creatingAllForOneStrategy
andOneForOneStrategy
. From the docs for these constructors:--
maxNrOfRetries
: the number of times a child actor is allowed to be restarted, negative value means no limit, if the limit is exceeded the child actor is stopped.--
withinTimeMilliseconds
: duration in milliseconds of the time window for maxNrOfRetries, negative values means no window.#689 made these calls do the incorrect thing: