Revert parts of #691 "refactor suspend children" #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a435803. The previous version was optimized for the most common scenario, when exceptFor == null. The LINQ expression introduced in akkadotnet#691 is creating a list every time and uses more enumerators.
rogeralsing
added a commit
that referenced
this pull request
Mar 1, 2015
Revert parts of #691 "refactor suspend children"
|
Again, I would like to see this kind of optimization justified. Suspend actors is not a thing you do 1000x per second, I think. I can't believe that you don't think the linq version is more readable. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts parts of commit a435803.
The previous version was optimized for the most common scenario, when
exceptFor == null.The LINQ expression introduced in #691 is creating a list every time and uses more enumerators. It also makes a call to
List<T>.Contains()when we know it's not necessary.Normally LINQ expression can make loops more readable, bu in this case, and it might come down to a matter of taste, I don't think the LINQ version was more readable.