Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on Title and Description for a PR in CONTRIBUTING.md #698

Merged
merged 1 commit into from
Mar 1, 2015

Conversation

HCanber
Copy link
Contributor

@HCanber HCanber commented Mar 1, 2015

A PR should always be justified.
As a few PR lately have slipped through without any description at all, except a title saying "Refactor Xyz" I thought it could be useful to have a paragraph we could point contributors to.

Maybe a native English speaker could have a look at what I've written. :)

rogeralsing added a commit that referenced this pull request Mar 1, 2015
Add info on Title and Description for a PR in CONTRIBUTING.md
@rogeralsing rogeralsing merged commit df0c021 into akkadotnet:dev Mar 1, 2015
@Aaronontheweb
Copy link
Member

@HCanber I think this is great - we should also include the following:

DON'T DO:

DO:

@HCanber
Copy link
Contributor Author

HCanber commented Mar 2, 2015

Any suggestions to what to put under those headings?

@HCanber HCanber deleted the pr-title-and-description branch March 29, 2015 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants