Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MS.EXT and System package versioning to ranged #7029

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

Arkatufus
Copy link
Contributor

Fixes #5411

Changes

Change Microsoft.Extensions.* and System.* package versioning to use range instead of fixed versioning

@Arkatufus Arkatufus marked this pull request as draft December 28, 2023 19:20
@Arkatufus Arkatufus marked this pull request as ready for review December 28, 2023 19:35
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Copyright (C) 2013-${CurrentDate.Year} .NET Foundation <https://github.com/akkadotnet/akka.net>
// </copyright>
//-----------------------------------------------------------------------</s:String>
<s:String x:Key="/Default/CodeStyle/FileHeader/FileHeaderText/@EntryValue">-----------------------------------------------------------------------&#xD;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, glad someone finally fixed this - ty @Arkatufus

@@ -37,7 +37,8 @@
<HoconVersion>2.0.3</HoconVersion>
<ConfigurationManagerVersion>6.0.1</ConfigurationManagerVersion>
<MultiNodeAdapterVersion>1.5.13</MultiNodeAdapterVersion>
<MicrosoftLibVersion>5.0.0</MicrosoftLibVersion>
<MicrosoftLibVersion>[6.0.*,)</MicrosoftLibVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,8 +12,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="7.0.1" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="$(MsExtVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="[3.1.0,)" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(MsExtVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 29, 2023 14:15
@Aaronontheweb Aaronontheweb merged commit 2633f91 into akkadotnet:dev Dec 29, 2023
9 of 12 checks passed
@Aaronontheweb Aaronontheweb added this to the 1.5.15 milestone Dec 29, 2023
@Aaronontheweb Aaronontheweb added dependencies Pull requests that update a dependency file akka-dependency-injection Akka.DI-related issues labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-dependency-injection Akka.DI-related issues dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to set version range for all standard System.* packages
2 participants