Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made examples, benchmarks, and internal libraries unpackable #7263

Merged

Conversation

Aaronontheweb
Copy link
Member

Working on some future-proofing for the build system so we can migrate off of FAKE and eventually just do everything with dotnet plus some other external dotnet tool commands like incrementalist and docfx.

One thing we need in order to do this is to make it possible to run dotnet publish on the src/Akka.sln file itself is to lock down which projects can actually be published. This hasn't been an issue with production NuGet deploys yet but I ran into this as soon as I tried some local builds on Linux.

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) June 23, 2024 22:27
@Aaronontheweb Aaronontheweb disabled auto-merge June 23, 2024 23:30
@Aaronontheweb
Copy link
Member Author

Tests failed because of Akka.Tests.Shared.Internal got touched, but these were some of the usual suspect racy specs - not anything affected by this change

@Aaronontheweb Aaronontheweb merged commit 299fedf into akkadotnet:dev Jun 23, 2024
8 of 12 checks passed
@Aaronontheweb Aaronontheweb deleted the make-examples-not-packable branch June 23, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant