Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASE_NOTES.md for 1.5.27.1 #7306

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Update RELEASE_NOTES.md for 1.5.27.1 #7306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53788b9
Fix remoting logging DefaultAddress race condition
Arkatufus Jul 25, 2024
62f6210
Update RELEASE_NOTES.md for 1.5.27.1 release
Arkatufus Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
#### 1.5.28 July 25th 2024 ####
#### 1.5.27.1 July 25th 2024 ####

*Placeholder for nightlies*
Akka.NET v1.5.27.1 is a minor patch to fix a race condition between the logging and remoting system.

* [Akka: Fix Remoting-Logging DefaultAddress race condition](https://github.com/akkadotnet/akka.net/pull/7305)

To [see the full set of changes in Akka.NET v1.5.27.1, click here](https://github.com/akkadotnet/akka.net/milestone/110).

| COMMITS | LOC+ | LOC- | AUTHOR |
|---------|------|------|---------------------|
| 1 | 4 | 0 | Aaron Stannard |
| 1 | 10 | 3 | Gregorius Soedharmo |

#### 1.5.27 July 25th 2024 ####

Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.Remote/RemoteActorRefProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public ActorPath RootPath
public Deployer Deployer { get; protected set; }

/// <inheritdoc/>
public Address DefaultAddress { get { return Transport.DefaultAddress; } }
public Address DefaultAddress { get { return Transport?.DefaultAddress; } }

private Information _serializationInformationCache;

Expand Down
11 changes: 9 additions & 2 deletions src/core/Akka/Event/Logging.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,15 @@ public static string FromActor(IActorContext actor, ActorSystem system)

public static string FromActorRef(IActorRef a, ActorSystem system)
{
var defaultAddress = system.AsInstanceOf<ExtendedActorSystem>().Provider.DefaultAddress;
return defaultAddress is null ? a.Path.ToString() : a.Path.ToStringWithAddress(defaultAddress);
try
{
var defaultAddress = system.AsInstanceOf<ExtendedActorSystem>().Provider.DefaultAddress;
return defaultAddress is null ? a.Path.ToString() : a.Path.ToStringWithAddress(defaultAddress);
}
catch // can fail if the ActorSystem (remoting) is not completely started yet
{
return a.Path.ToString();
}
}
}

Expand Down
Loading