fixed Akka.Persistence.Tck snapshot load specs #7320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Left-over bugs from akkadotnet#7313
Aaronontheweb
commented
Aug 16, 2024
| @@ -184,7 +185,7 @@ public virtual void SnapshotStore_should_load_the_most_recent_snapshot_matching_ | |||
| public virtual void SnapshotStore_should_delete_a_single_snapshot_identified_by_SequenceNr_in_snapshot_metadata() | |||
| { | |||
| var md = Metadata[2]; | |||
| md = new SnapshotMetadata(md.PersistenceId, md.SequenceNr, Sys.Scheduler.Now.DateTime); | |||
| md = new SnapshotMetadata(md.PersistenceId, md.SequenceNr, md.Timestamp); | |||
There was a problem hiding this comment.
Basic issue with the test before was that we were using the wrong timestamp so Metadata[2]; never got deleted because now timestamps matter. Adjusted the SnapshotMetadata to use the same timestamp as the targeted snapshot so the test assertions pass without being changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Left-over bugs from #7313
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
DateTime.UtcNowthe default timestamp forSnapshotMetdata#7313