Add per-plugin recovery permitter actors #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Design looks good - but we should add some specs:
- Validate that we look for a plugin-specific
max-concurrent-recoveriesand that that can override the global default - Validate, with a quick test against the
Persistenceextension itself, that multiple recovery permitter actors are created if multiple journals are defined.
No need for a big End2End integration spec, I think that should be fine.
| @@ -166,6 +167,8 @@ public IStash Stash | |||
| /// </summary> | |||
| public IActorRef Journal => _journal ??= Extension.JournalFor(JournalPluginId); | |||
|
|
|||
| internal IActorRef RecoveryPermitter => _recoveryPermitter ??= Extension.RecoveryPermitterFor(JournalPluginId); | |||
| } | ||
|
|
||
| public IActorRef Ref { get; } | ||
|
|
||
| public EventAdapters Adapters { get; } | ||
|
|
||
| public Config Config { get; } | ||
|
|
||
| public IActorRef RecoveryPermitter { get; } |
| @@ -303,8 +310,9 @@ private static PluginHolder NewPluginHolder(ExtendedActorSystem system, string c | |||
| var config = system.Settings.Config.GetConfig(configPath).WithFallback(system.Settings.Config.GetConfig(fallbackPath)); | |||
| var plugin = CreatePlugin(system, configPath, config); | |||
| var adapters = CreateAdapters(system, configPath); | |||
| var recoveryPermitter = CreateRecoveryPermitter(system, configPath, config); | |||
Arkatufus
commented
Jan 8, 2025
| @@ -81,6 +81,7 @@ public abstract partial class Eventsourced : ActorBase, IPersistentIdentity, IPe | |||
| private readonly IStash _internalStash; | |||
| private IActorRef _snapshotStore; | |||
| private IActorRef _journal; | |||
| private IActorRef _recoveryPermitter; | |||
There was a problem hiding this comment.
The recovery permitter is being cached here instead of in the Persistence extension. This is lazily created when the plugin is initialized for the first time.
| @@ -166,6 +167,8 @@ public IStash Stash | |||
| /// </summary> | |||
| public IActorRef Journal => _journal ??= Extension.JournalFor(JournalPluginId); | |||
|
|
|||
| internal IActorRef RecoveryPermitter => _recoveryPermitter ??= Extension.RecoveryPermitterFor(JournalPluginId); | |||
There was a problem hiding this comment.
Lazy instantiation
| { | ||
| Ref = @ref; | ||
| Adapters = adapters; | ||
| Config = config; | ||
| RecoveryPermitter = recoveryPermitter; |
There was a problem hiding this comment.
Recovery permitter is also cached inside the PluginHolder so that it can be looked up.
| @@ -152,9 +147,10 @@ public string PersistenceId(IActorRef actor) | |||
| /// INTERNAL API: When starting many persistent actors at the same time the journal its data store is protected | |||
| /// from being overloaded by limiting number of recoveries that can be in progress at the same time. | |||
| /// </summary> | |||
| internal IActorRef RecoveryPermitter() | |||
| internal IActorRef RecoveryPermitterFor(string journalPluginId) | |||
There was a problem hiding this comment.
Same design as AdaptersFor() to look up recovery permitter actor per plugin basis
…fus/akka.net into Add-per-plugin-recovery-permitter
|
Done adding spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7447
Changes
All changes are applied to internal APIs.
Persistenceextension to eachEventSourcedactors.RecoveryPermitteractor is now lazily created and stored inside persistencePluginHolderChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):