Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganized dependencies into separate paths for .NET Standard, .NET 6/8+ #7453

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jan 9, 2025

Changes

No material changes other than reducing the number of NuGet packages .NET 6+ users need to install.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb Aaronontheweb added the dependencies Pull requests that update a dependency file label Jan 9, 2025
@Aaronontheweb Aaronontheweb added this to the 1.5.35 milestone Jan 9, 2025
Copy link
Member Author

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed my changes

</ItemGroup>

<!-- Packages only for NetStandard -->
<ItemGroup Condition="'$(TargetFramework)' == '$(NetStandardLibVersion)'">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't need Polyfill on newer versions of .NET where record et al are natively supported
  • Don't need System.Reflection.Emit (built into BCL)
  • Don't need System.Threading.Channels (built into BCL)

These are pre-requisites for supporting #6855 - which is going to require a System.Diagnostics.Activity dependency for netstandard2.0 only.

@Aaronontheweb Aaronontheweb merged commit 9c64ecb into akkadotnet:dev Jan 9, 2025
7 of 12 checks passed
@Aaronontheweb Aaronontheweb deleted the cleanup-dependencies branch January 9, 2025 23:00
Aaronontheweb added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant