Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DData: Fix BCL update causing DeltaPropagationSelector throwing IndexOutOfBoundException #7462

Merged
merged 1 commit into from
Jan 13, 2025
Merged

DData: Fix BCL update causing DeltaPropagationSelector throwing IndexOutOfBoundException #7462

merged 1 commit into from
Jan 13, 2025

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jan 13, 2025 •
edited
Loading

BCL 8.0 does not allow slice end index to go out of bound (breaking behavior)

Changes

Add index out of bound checking

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Aaronontheweb
Aaronontheweb approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 13, 2025 17:11
@Aaronontheweb Aaronontheweb merged commit 5c7c967 into akkadotnet:dev Jan 13, 2025
12 checks passed
@Arkatufus Arkatufus mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-ddata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb