Merge of #762 #776
Merged
Merge of #762 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: ActorRef == and != has been removed. This means all actorRef1 == actorRef2 must be replaced with Equals(actorRef1, actorRef2) Tell(object message), ie the implicit sender overload, has been moved to an extension method, and requires a "using Akka.Actor;" ActorRef.NoSender -> ActorRefs.NoSender ActorRef.Nobody -> ActorRefs.Nobody Implicit cast from ActorRef to Routee has been replaced with Routee.FromActorRef(actorRef) You might need to add a using Akka.Actor; to be able to use Tell with implicit sender.
From now on, an ActorRef implementation need to implement both ActorRef and InternalActorRef interfaces. Before this was the ActorRef hiearchy. Every ActorRef (except NoSender) had to inherit from InternaActorRef Akka.Actor.ActorRef + Akka.Actor.InternalActorRef | + Akka.Actor.ActorRefWithCell | | + Akka.Actor.LocalActorRef | | | + Akka.Actor.RootGuardianActorRef | | | + Akka.TestKit.TestActorRef<T> | | + Akka.Actor.RepointableActorRef ... (other classes removed) + Akka.Actor.NoSender Now ActorRef and InternalActorRef are interfaces and we have two new base classes: ActorRefBase : ActorRef and InternalActorRefBase : ActorRefBase, InternalActorRef and the hierarchy is: Akka.Actor.ActorRef + Akka.Actor.ActorRefBase | + Akka.Actor.InternalActorRefBase | | + Akka.Actor.ActorRefWithCell | | | + Akka.Actor.LocalActorRef | | | | + Akka.Actor.RootGuardianActorRef ... (other classes removed) However there is no need for ActorRefs to inherit from the base classes. Implementing InternalActorRef is a requirement though.
|
Beautiful, green check mark. And with that I hereby declare AKKA.NET V1 CODE COMPLETEGreat job everyone cc @akkadotnet/contributors |
Aaronontheweb
added a commit
that referenced
this pull request
Mar 30, 2015
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #762 for original PR notes. This merges @HCanber's changes in with all of the other changesets going into V1.