Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More interface prefixing #801

Merged
merged 4 commits into from
Apr 7, 2015
Merged

More interface prefixing #801

merged 4 commits into from
Apr 7, 2015

Conversation

SeanKilleen
Copy link
Contributor

Leftovers from #782.

Below is my target list of interfaces, per @HCanber's comment on #652 and what he hadn't hit yet:

  • Akka.Dispatch.SysMsg.SystemMessage, Akka (Public)
  • Akka.Event.LoggingAdapter, Akka (Public)
  • Akka.FluentConfigInternals, Akka (Public)
  • Akka.Remote.InboundMessageDispatcher, Akka.Remote
  • Akka.Remote.RemoteRef, Akka.Remote
  • Akka.Routing.ConsistentHashable, Akka (Public)

@SeanKilleen SeanKilleen changed the title More interface prefixing Work in Progress: More interface prefixing Apr 7, 2015
@SeanKilleen
Copy link
Contributor Author

FYI, I can't find Akka.FluentConfigInternals -- assuming it was renamed somewhere. Checking it off for now but I'll get it in a future pass.

@SeanKilleen
Copy link
Contributor Author

Note: IConsistentHashable already existed.

@SeanKilleen SeanKilleen changed the title Work in Progress: More interface prefixing More interface prefixing Apr 7, 2015
@SeanKilleen SeanKilleen mentioned this pull request Apr 7, 2015
Closed
@stefansedich
Copy link
Contributor

Looks good to me, any objections from anyone if I merge once the build passes? @akkadotnet/contributors

@Aaronontheweb
Copy link
Member

@stefansedich go for it - all yours.

@Aaronontheweb
Copy link
Member

FYI, I can't find Akka.FluentConfigInternals -- assuming it was renamed somewhere. Checking it off for now but I'll get it in a future pass.

We deleted it - removed FluentConfig in an earlier PR.

@SeanKilleen SeanKilleen mentioned this pull request Apr 7, 2015
Closed
11 tasks
stefansedich added a commit that referenced this pull request Apr 7, 2015
@stefansedich
Merge pull request #801 from SeanKilleen/dev
0d549a6 
More interface prefixing
@stefansedich stefansedich merged commit 0d549a6 into akkadotnet:dev Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeanKilleen @stefansedich @Aaronontheweb