Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(messaging): support for frameId #88

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

Mehdi-Hp
Copy link
Contributor

@Mehdi-Hp Mehdi-Hp commented Jan 8, 2025

Adding support for optional frameId in Browser.tabs.sendMessage

Copy link
Owner

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and updating the tests.

One small change, I prefer to avoid runtime type-checks if typescript already reports as fine. The error the browser throws in those cases is good enough.

@aklinker1 aklinker1 changed the title feat(messaging): support for frameId feat(messaging): support for frameId Jan 9, 2025
@aklinker1
Copy link
Owner

aklinker1 commented Jan 9, 2025

Looks like there are some type errors in src/extension.test-d.ts causing checks to fail

@Mehdi-Hp
Copy link
Contributor Author

Looks like there are some type errors in src/extension.test-d.ts causing checks to fail

Fixed.
Updated the docs too, but I think that needs your edit.

@aklinker1 aklinker1 merged commit 63f961c into aklinker1:main Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants