Describe cluster API Support #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Sep 17, 2024
Comment on lines
591
to
592
| struct ClusterBroker | ||
| { |
There was a problem hiding this comment.
Suggested change
| struct ClusterBroker | |
| { | |
| struct ClusterBroker | |
| { |
| string16 host; | ||
| int32 port; | ||
| string16 rack = null; | ||
| } |
There was a problem hiding this comment.
Let's move this structure down between DescribeClusterResponse and DescribeClusterResponsePart2 as it is part of the response and logically belongs between these structures.
Comment on lines
560
to
563
| case 60: kafka::stream::KafkaDescribeClusterRequestBeginEx describeCluster; | ||
| case 33: kafka::stream::KafkaAlterConfigsRequestBeginEx alterConfigs; | ||
| case 20: kafka::stream::KafkaDeleteTopicsRequestBeginEx deleteTopics; | ||
| case 19: kafka::stream::KafkaCreateTopicsRequestBeginEx createTopics; |
There was a problem hiding this comment.
Let's put these in the order of their api key, increasing.
Comment on lines
41
to
42
| .brokerId(0) | ||
| .host("localhost0") |
There was a problem hiding this comment.
Let's use more meaningful broker ids and host names, like 0xb1 and broker-1.internal.net or similar.
I think we might have some examples of that in other scripts.
jfallows
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See 1058