Replace Ivy APIs with embedded Maven during zpmw install #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Nov 27, 2024
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmRepository.java
Outdated
Show resolved
Hide resolved
...ger/src/main/java/io/aklivity/zilla/manager/internal/commands/install/cache/ZpmArtifact.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/cache/ZpmCache.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
Nov 27, 2024
cloud/docker-image/src/main/docker/incubator/debug_krishna.pcap
Outdated
Show resolved
Hide resolved
jfallows
previously approved these changes
Nov 27, 2024
bmaidics
force-pushed
the
maven_resolver
branch
from
6071769 to
80c30e2
Compare
jfallows
requested changes
Dec 9, 2024
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/cache/ZpmCache.java
Show resolved
Hide resolved
jfallows
requested changes
Dec 9, 2024
manager/src/main/java/io/aklivity/zilla/manager/internal/commands/install/ZpmInstall.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
Dec 10, 2024
jfallows
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1173