Better handling negative edge cases in the connection pool #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artial data frame while computing crc32c value
jfallows
requested changes
Nov 2, 2023
| @@ -81,6 +82,7 @@ public class KafkaConfiguration extends Configuration | |||
| KAFKA_CLIENT_INSTANCE_ID = config.property(InstanceIdSupplier.class, "client.instance.id", | |||
| KafkaConfiguration::decodeInstanceId, KafkaConfiguration::defaultInstanceId); | |||
| KAFKA_CLIENT_MAX_IDLE_MILLIS = config.property("client.max.idle.ms", 1 * 60 * 1000); | |||
| KAFKA_CLIENT_CONNECTION_POLL_CLEANUP_MILLIS = config.property("client.connection.pool.cleanup.millis", 4 * 1000L); | |||
There was a problem hiding this comment.
Suggested change
| KAFKA_CLIENT_CONNECTION_POLL_CLEANUP_MILLIS = config.property("client.connection.pool.cleanup.millis", 4 * 1000L); | |
| KAFKA_CLIENT_CONNECTION_POOL_CLEANUP_MILLIS = config.property("client.connection.pool.cleanup.millis", 4 * 1000L); |
| @@ -29,6 +30,8 @@ public class KafkaConfigurationTest | |||
| public static final String KAFKA_CLIENT_PRODUCE_MAX_REQUEST_MILLIS_NAME = | |||
| "zilla.binding.kafka.client.produce.max.request.millis"; | |||
| public static final String KAFKA_CLIENT_PRODUCE_MAX_BYTES_NAME = "zilla.binding.kafka.client.produce.max.bytes"; | |||
| public static final String KAFKA_CLIENT_CONNECTION_POLL_CLEANUP_MILLIS_NAME = | |||
There was a problem hiding this comment.
Suggested change
| public static final String KAFKA_CLIENT_CONNECTION_POLL_CLEANUP_MILLIS_NAME = | |
| public static final String KAFKA_CLIENT_CONNECTION_POOL_CLEANUP_MILLIS_NAME = |
jfallows
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #557