Add end-to-end testing for the dump command
#646
Merged
+2,427
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
previously approved these changes
Dec 19, 2023
jfallows
requested changes
Dec 20, 2023
.../test/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommandTest.java
Outdated
Show resolved
Hide resolved
.../test/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommandTest.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Dec 20, 2023
| @@ -5,7 +5,7 @@ The `dump` command creates a `pcap` file that can be opened by Wireshark using t | |||
| This is the command to build a multi-arch `tshark` image and push it to a docker repository: | |||
|
|
|||
| ```bash | |||
| cd <zilla-source>/incubator/command-dump/src/test/resources/io/aklivity/zilla/runtime/command/dump/internal | |||
| cd <zilla-source>/incubator/command-dump/src/test/resources/io/aklivity/zilla/runtime/command/dump/internal/airline | |||
There was a problem hiding this comment.
Do we need to have the Dockerfile in the test jar?
If not we can move this to src/test/docker instead so the instructions are a bit simpler.
There was a problem hiding this comment.
Yes, we need it. The setUp method here is implemented the way that it tries to find/pull the image first and if doesn't find it, then builds it on-the-fly.
ImageFromDockerfile image = new ImageFromDockerfile().withDockerfile(resourceToPath("Dockerfile"));
incubator/command-dump/pom.xml
Outdated
Comment on lines
106
to
107
| <exclude>src/test/resources/io/aklivity/zilla/runtime/command/dump/internal/airline/*</exclude> | ||
| <exclude>src/test/resources/io/aklivity/zilla/runtime/command/dump/internal/airline/engine/*</exclude> |
There was a problem hiding this comment.
Can we scope the files a little more tightly so that new resources get caught automatically?
For example src/test/resources/**/*.pcap etc.
There was a problem hiding this comment.
fixed, pls chk
jfallows
approved these changes
Dec 22, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds end-to-end testing to the
dumpcommand that includes the builders, thepcapgeneration, runstsharkindockerwith theluadissector and the captures the output.