migrating from Validator to Converter #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jan 11, 2024
cloud/docker-image/pom.xml
Outdated
| @@ -344,25 +344,25 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>validator-avro</artifactId> | |||
| <artifactId>type-avro</artifactId> | |||
There was a problem hiding this comment.
We had agreed on types-, not type-.
Please adjust the module names and module-info accordingly.
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package io.aklivity.zilla.runtime.converter.avro; |
There was a problem hiding this comment.
Package name should match the module, so io.aklivity.zilla.runtime.types.avro.
Please make a similar adjustment to the other types-* modules.
jfallows
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.