Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly update the properties for all build configurations #13

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Correctly update the properties for all build configurations #13

merged 1 commit into from
Sep 2, 2016

Conversation

bugnano
Copy link
Contributor

@bugnano bugnano commented Sep 1, 2016

This fixes issue #12

The problem is that getBuildProperty without the last parameter returns only the value of one of the many available build configurations.

Now, what happens if the value returned by getBuildProperty has the expected value, but the other build configurations still have the wrong value? Simple: the plugin (wrongly) assumes that the value does not need to be changed, so it does not update its value, which results in a Cordova project that works in one build configuration, but is totally broken when changing build configuration.

This patch fixes the problem by iterating through each build configuration, and updating the values accordingly.

@akofman
Copy link
Owner

akofman commented Sep 1, 2016

Thanks ! I'm gonna review that in the week.

@betko
Copy link

betko commented Sep 2, 2016

I would like to ask when do you plan to release the fix for this issue?
Thanks in advance.

@akofman
Copy link
Owner

akofman commented Sep 2, 2016

Hello @betko I have no precise planning cause I do that on my personal time. But probably before the end of the day ;)

@betko
Copy link

betko commented Sep 2, 2016

It is sounds good. Thank you. 😸

@akofman akofman merged commit 9a89a97 into akofman:master Sep 2, 2016
@akofman
Copy link
Owner

akofman commented Sep 2, 2016

Awesome, thanks @bugnano 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants