Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could AtomicUsize be used instead of AtomicU64? #1

Open
SimonSapin opened this issue Dec 20, 2017 · 0 comments · May be fixed by #2
Open

Could AtomicUsize be used instead of AtomicU64? #1

SimonSapin opened this issue Dec 20, 2017 · 0 comments · May be fixed by #2

Comments

@SimonSapin
Copy link

SimonSapin commented Dec 20, 2017 •
edited
Loading

This would make get_timestamp() wrap after "only" four billion and some calls, on 32-bit platforms. Is that acceptable? (I don’t really know what timestamps are used for.)

AtomicU64 is the only unstable Rust feature used in this crate. Removing it would help with servo/servo#5286.
SimonSapin added a commit to SimonSapin/blurmac that referenced this issue Jan 4, 2018
@SimonSapin
Remove usage of unstable AtomicU64 / integer_atomics
517ceb5 
Use AtomicUsize instead. Fix akosthekiss#1.
It behaves the same, since macOS is always 64-bit these days.

Increment the version number to 0.1.0 rather than 0.0.2
so that it is possible next time to do version number changes
that Cargo does not consider breaking.
@SimonSapin SimonSapin linked a pull request Jan 4, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usage of unstable AtomicU64 / integer_atomics SimonSapin/blurmac
1 participant
@SimonSapin