Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove deprecated Logger.warn/2 calls #207

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

aleagnelli
Copy link
Contributor

@aleagnelli aleagnelli commented Jun 21, 2023

With elixir 1.15.0 Logger.warn/2 is deprecated in favor of Logger.warning/2, also aligned the example project

@coveralls
Copy link

coveralls commented Jun 21, 2023

Coverage Status

coverage: 78.698% (-0.07%) from 78.771% when pulling e4e61b0 on aleagnelli:master into b80c52e on akoutmos:master.

@aleagnelli
Copy link
Contributor Author

Not sure why the test is failing in ci only for otp-24, @akoutmos anyway i can help?

@axelson
Copy link

axelson commented Aug 24, 2023

Friendly ping :)

Selfishly It would be nice to get this merged so that our deps compilation is quieter 😃

@akoutmos
Copy link
Owner

Sorry for the delay. Merging this in and will sort out the failed tests. Thanks for the update!

@akoutmos akoutmos merged commit e072914 into akoutmos:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants