Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend relative volumes with absolute path #21

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

aksiksi
Copy link
Owner

@aksiksi aksiksi commented Jun 1, 2024

Closes #17.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.31%. Comparing base (d20f7ac) to head (34620cf).

Files Patch % Lines
compose.go 70.37% 7 Missing and 1 partial ⚠️
main.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   73.32%   73.31%   -0.02%     
==========================================
  Files           6        6              
  Lines         851      873      +22     
==========================================
+ Hits          624      640      +16     
- Misses        190      197       +7     
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aksiksi aksiksi merged commit 9dacdf1 into main Jun 1, 2024
3 checks passed
@aksiksi aksiksi deleted the volume-relative-path branch June 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should compose2nix reconsider relative volumes mounts from cwd?
2 participants