fix: detect duplicate env files between CLI and Compose #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 73.03% 73.17% +0.14%
==========================================
Files 6 6
Lines 749 753 +4
==========================================
+ Hits 547 551 +4
Misses 163 163
Partials 39 39 ☔ View full report in Codecov by Sentry. |
aksiksi
force-pushed
the
duplicate-env-file
branch
from
2b8c673 to
39a9183
Compare
If the same env file is passed via CLI and set in the Compose `env_file` for a service, then we do not want to include the env file twice. To achieve this, we map the CLI env files into absolute paths to ensure that we can compare them with env_file entries returned by the Compose library.
aksiksi
force-pushed
the
duplicate-env-file
branch
from
39a9183 to
c5ae726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.