feat: initial support for Compose Build spec #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 73.34% 74.13% +0.79%
==========================================
Files 6 6
Lines 769 812 +43
==========================================
+ Hits 564 602 +38
- Misses 164 165 +1
- Partials 41 45 +4 ☔ View full report in Codecov by Sentry. |
aksiksi
force-pushed
the
build-spec
branch
5 times, most recently
from
dd1ccb0 to
775df6d
Compare
The idea is we generate a systemd (one-shot) service per build that users can run _manually_ to build the container and add it to the runtime's image store. Users can also pass in `-build=true` to enable the build service to run as a dependency for the container. However, keeping this config would result in a _new_ build on every restart of the system (or root target), which would implicitly result in an update of the container. For now, we do not support Git repo build contexts (i.e., pull from repo before building).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is we generate a systemd (one-shot) service per build that users can run manually to build the container and add it to the runtime's image store.
Users can also pass in
-build=trueto enable the build service to run as a dependency for the container. However, keeping this config would result in a new build on every restart of the system (or root target), which would implicitly result in an update of the container. So, users will need to re-generate the config with-build=false.For now, we do not support Git repo build contexts (i.e., pull from repo before building).